refactor(run_path): scope hook exit status to a single iteration#2552
Open
joshtrichards wants to merge 1 commit intomasterfrom
Open
refactor(run_path): scope hook exit status to a single iteration#2552joshtrichards wants to merge 1 commit intomasterfrom
joshtrichards wants to merge 1 commit intomasterfrom
Conversation
Limit return_code to the per-script failure path instead of keeping it as loop state. This does not change current behavior, but makes the code easier to reason about and avoids future stale-state bugs if the loop logic is refactored. Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not initialize and reuse
return_codeacross the whole loop when it is only needed for the current script execution.This is mostly a cleanup, but it also reduces the chance of accidentally acting on a stale non-zero status in future changes.